From d70f688f25a76e1e6a251a4ffc5144539c1a4e64 Mon Sep 17 00:00:00 2001 From: Damien George Date: Wed, 10 May 2017 12:30:34 +1000 Subject: [PATCH] extmod/vfs: Use MP_S_IFDIR, MP_S_IFREG consts instead of magic numbers. --- extmod/vfs.c | 2 +- extmod/vfs_fat.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/extmod/vfs.c b/extmod/vfs.c index 8db7d5e44..f158bd387 100644 --- a/extmod/vfs.c +++ b/extmod/vfs.c @@ -408,7 +408,7 @@ mp_obj_t mp_vfs_stat(mp_obj_t path_in) { mp_vfs_mount_t *vfs = lookup_path(path_in, &path_out); if (vfs == MP_VFS_ROOT) { mp_obj_tuple_t *t = MP_OBJ_TO_PTR(mp_obj_new_tuple(10, NULL)); - t->items[0] = MP_OBJ_NEW_SMALL_INT(0x4000); // st_mode = stat.S_IFDIR + t->items[0] = MP_OBJ_NEW_SMALL_INT(MP_S_IFDIR); // st_mode for (int i = 1; i <= 9; ++i) { t->items[i] = MP_OBJ_NEW_SMALL_INT(0); // dev, nlink, uid, gid, size, atime, mtime, ctime } diff --git a/extmod/vfs_fat.c b/extmod/vfs_fat.c index 41c32c6b6..0ec3fe6d2 100644 --- a/extmod/vfs_fat.c +++ b/extmod/vfs_fat.c @@ -225,9 +225,9 @@ STATIC mp_obj_t fat_vfs_stat(mp_obj_t vfs_in, mp_obj_t path_in) { mp_obj_tuple_t *t = MP_OBJ_TO_PTR(mp_obj_new_tuple(10, NULL)); mp_int_t mode = 0; if (fno.fattrib & AM_DIR) { - mode |= 0x4000; // stat.S_IFDIR + mode |= MP_S_IFDIR; } else { - mode |= 0x8000; // stat.S_IFREG + mode |= MP_S_IFREG; } mp_int_t seconds = timeutils_seconds_since_2000( 1980 + ((fno.fdate >> 9) & 0x7f),