From 2a1090a637e4877af443e57e133808f088848721 Mon Sep 17 00:00:00 2001 From: Damien George Date: Tue, 23 Jun 2015 16:08:51 +0000 Subject: [PATCH] py: Clarify comment in parsenum.c about ValueError vs SyntaxError. --- py/parsenum.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/py/parsenum.c b/py/parsenum.c index ae04aa426..c6174db65 100644 --- a/py/parsenum.c +++ b/py/parsenum.c @@ -36,7 +36,8 @@ #endif STATIC NORETURN void raise_exc(mp_obj_t exc, mp_lexer_t *lex) { - // if lex!=NULL then the parser called us and we need to make a SyntaxError with traceback + // if lex!=NULL then the parser called us and we need to convert the + // exception's type from ValueError to SyntaxError and add traceback info if (lex != NULL) { ((mp_obj_base_t*)exc)->type = &mp_type_SyntaxError; mp_obj_exception_add_traceback(exc, lex->source_name, lex->tok_line, MP_QSTR_NULL); @@ -142,7 +143,6 @@ overflow: } value_error: - // if lex!=NULL then the parser called us and we need to make a ValueError with traceback if (MICROPY_ERROR_REPORTING == MICROPY_ERROR_REPORTING_TERSE) { mp_obj_t exc = mp_obj_new_exception_msg(&mp_type_ValueError, "invalid syntax for integer");